ci: test upcoming Cranelift release branch#1643
ci: test upcoming Cranelift release branch#16430xmuon wants to merge 2 commits intorust-lang:mainfrom
Conversation
| on: | ||
| schedule: | ||
| # Run daily so we don't miss the release branch cut. | ||
| - cron: "0 3 * * *" |
There was a problem hiding this comment.
The release branch is automatically cut on the 5th, so running once on the 6th of every month would be enough. This way there is also no need to do caching. https://github.com/bytecodealliance/wasmtime/blob/40da1d8c83e2c5e35ab5245ff4b7a5a9592422c1/.github/workflows/release-process.yml#L5-L6
|
|
||
| defaults: | ||
| run: | ||
| shell: bash |
There was a problem hiding this comment.
This is the default already.
| if "[patch.crates-io]" not in s: | ||
| s += "\n\n[patch.crates-io]\n" | ||
|
|
||
| # Remove any previous CI-inserted patch block. |
There was a problem hiding this comment.
This isn't possible, right? This workflow doesn't modify the repo and each CI run has a fresh checkout of the repo. I think inserting the entire patch block at the end of Cargo.toml unconditionally would be enough.
There was a problem hiding this comment.
You are right, each workflow run starts from a fresh checkout, so removing a previous CI inserted block is unnecessary. I will simplify it to append the full [patch.crates-io] block to Cargo.toml.
2 participants
Fix: #1626
Added a scheduled workflow that patches
Craneliftdeps to the latestwasmtimerelease-*branch and runs the test suite.